Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix masking with more than one input feature #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix masking with more than one input feature #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions neural_tangents/_src/stax/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,11 @@ def get_x_cov_mask(x):
x = _get_masked_array(x, mask_constant)
x, mask = x.masked_value, x.mask

# reduce mask
if mask_constant and mask.shape[channel_axis] > 1:
warnings.warn("Assuming consistent masks (all zero or one) for features of dimension > 1, which is not verified.")
mask = np.any(mask, axis=channel_axis, keepdims=True)

# TODO(schsam): Think more about dtype automatic vs manual dtype promotion.
x = x.astype(jax.dtypes.canonicalize_dtype(np.float64))

Expand Down