Make take_bug_reports consistent with its singular version.

[xpconanfan]

Also simplify the timestamp generation logic.

---

This change is 

[winterfroststrom]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @winterfroststrom and @xpconanfan)

---

mobly/controllers/android_device.py, line 408 at r1 (raw file):

_begin_time

Is there a reason against using begin_time directly?
it's a string reference right? so it should be immutable.

[xpconanfan]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @winterfroststrom and @xpconanfan)

---

mobly/controllers/android_device.py, line 408 at r1 (raw file):

Previously, winterfroststrom wrote…

_begin_time

Is there a reason against using begin_time directly?
it's a string reference right? so it should be immutable.

I don't think you are supposed to reassign params?

[winterfroststrom]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @xpconanfan)

---

mobly/controllers/android_device.py, line 408 at r1 (raw file):

Previously, xpconanfan (Ang Li) wrote…

I don't think you are supposed to reassign params?

Isn't
if param is None:
param = ...

A really common pattern with default params?

[xpconanfan]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @winterfroststrom and @xpconanfan)

---

mobly/controllers/android_device.py, line 408 at r1 (raw file):

Previously, winterfroststrom wrote…

Isn't
if param is None:
param = ...

A really common pattern with default params?

Done.

[winterfroststrom]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @xpconanfan)

---

mobly/controllers/android_device.py, line 408 at r1 (raw file):

Previously, xpconanfan (Ang Li) wrote…

Done.

what if begin_time needs to be explicitly empty string for some reason?
would it be worthwhile to change the check to "begin_time is None" instead for that

[xpconanfan]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @xpconanfan)

---

mobly/controllers/android_device.py, line 408 at r1 (raw file):

Previously, winterfroststrom wrote…

what if begin_time needs to be explicitly empty string for some reason?
would it be worthwhile to change the check to "begin_time is None" instead for that

I don't think it's a valid use case.
But changed anyway.

[winterfroststrom]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @xpconanfan)