Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround socket library import issue. #601

Merged
merged 4 commits into from
Jul 16, 2019
+12 −0
Merged

Workaround socket library import issue. #601

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d360d8
Workaround socket library import issue.
winterfroststrom Jul 13, 2019
db4bd4f
documentation changes
winterfroststrom Jul 15, 2019
0a04b19
Remove supposedly.
winterfroststrom Jul 16, 2019
14a5a4d
Add back accidentally removed S
winterfroststrom Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions mobly/controllers/android_device_lib/jsonrpc_client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,18 @@

from builtins import str

# When the Python library `socket.create_connection` call is made, it indirectly
# calls `import encodings.idna` through the `socket.getaddrinfo` method.
# However, this chain of function calls is apparently not thread-safe in
# embedded Python environments. So, pre-emptively import and cache the encoder.
# See https://bugs.python.org/issue17305 for more details.
try:
import encodings.idna
except ImportError:
# Some implementations of Python (e.g. IronPython) do not support the`idna`
# encoding, so ignore import failures based on that.
pass

import json
import socket
import threading
Expand Down