[BC] Multiprocessing fix and change to avoid Issue #391 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convention. Initial fix to Issue google#391 by parsing the gin config sting in ModuleExplorer instead of wrapping mlgo_task_type to pass it's arguments directly.
generate_bc_trajectories into a separate file.
mtrofin
approved these changes
Nov 21, 2024
| @@ -742,7 +741,7 @@ def __init__( | |||
| clang_path: str = gin.REQUIRED, | |||
| mlgo_task_type: Type[env.MLGOTask] = gin.REQUIRED, | |||
| policy_paths: List[Optional[str]] = [], | |||
| exploration_frac: float = gin.REQUIRED, | |||
| exploration_frac: float = 1.0, | |||
| @@ -869,7 +868,7 @@ def select_best_exploration( | |||
| def gen_trajectories( | |||
| # pylint: disable=dangerous-default-value | |||
| data_path: str = gin.REQUIRED, | |||
| delete_flags: Tuple[str, ...] = gin.REQUIRED, | |||
| delete_flags: Tuple[str, ...] = (), | |||
There was a problem hiding this comment.
For both default parameter changes -- I realized that these should not be gin.REQUIRED and they have standard default values. For exploration_frac the normal behavior is to set it to 1.0 and not constrain the number of exploration steps, for delete_flags the default behavior should be not to delete any flags.
mtrofin
reviewed
Dec 4, 2024
| @@ -341,6 +338,8 @@ def __init__( | |||
| 'reward_key not specified in ModuleExplorer initialization.') | |||
| self._reward_key = reward_key | |||
| kwargs.pop('reward_key', None) | |||
| gin_config_str = kwargs.pop('gin_config_str', None) | |||
| gin.parse_config(gin_config_str) | |||
There was a problem hiding this comment.
add a gin.clear_config() here. In test, for example, previous tests that do a gin.bind_parameter can mess things up.
separate issue: what we need to do with gin.bind_parameter in tests (in a maintainable way)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main from generate_bc_trajectories needs to be in a separate file otherwise cloudpickle fails. To avoid Issue #391 we also parse the gin config for
mlgo_task_typein eachModuleExplorersub-process.