Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC] Initial fix to #391 and rename generate_bc_trajectories* #392

Closed
wants to merge 0 commits into from

Conversation

tvmarino
Copy link
Collaborator

Update names of generate_bc_trajectories* to match the repo naming. Initial fix to Issue #391 by parsing the gin config sting in ModuleExplorer instead of wrapping mlgo_task_type to pass it's arguments directly.

Copy link
Collaborator

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for you to rename the files and fix #391 in separate PRs? It's hard to tease apart the fix to #391 from the refactor with how large the diff is from the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants