Add get_path_to_page_configs #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this method for downstream usage integration.
wwwillchen
approved these changes
Sep 6, 2024
| @@ -123,6 +124,9 @@ def register_page(self, *, path: str, page_config: PageConfig) -> None: | |||
| def get_page_config(self, *, path: str) -> PageConfig | None: | |||
| return self._path_to_page_config.get(path) | |||
There was a problem hiding this comment.
I'm wondering if we should also add a deepcopy to this method, but that's a bit orthogonal to this PR.
There was a problem hiding this comment.
I think the page config object is small enough that the deepcopy probably wouldn't be noticeable performance-wise. And doesn't seem like it's called a lot. I can add it as a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this method for downstream usage integration.