Fix cutoff content for history prompt list / code diff viewer #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the Angular dialog sets a 65vh. But our code is using 80vh. So I set it to 65vh to match. One consideration though is whether this 65vh changes dynamically or not. I did try adjusting viewport sizes in Chrome dev tools and it seemed like it stayed at 65vh but not sure. Closes google#908
wwwillchen
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Angular dialog sets a 65vh. But our code is using 80vh. So I set it to 65vh to match.
One consideration though is whether this 65vh changes dynamically or not. I did try adjusting viewport sizes in Chrome dev tools and it seemed like it stayed at 65vh but not sure.
Closes #908