Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup reasonable default web security policies #270

Merged
merged 1 commit into from
May 17, 2024
Merged

Setup reasonable default web security policies #270

merged 1 commit into from
May 17, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented May 17, 2024 •
edited
Loading

Fixes #225. I opened up #271 because it's the remaining major web security piece we should shore up.

Notes:

  • CSP is quite easy to mess up due to weird syntax it uses, so I've done a snapshot test to avoid accidental regressions.
  • Using CSP nonce requires us to generate a random string and set it on the server (ref)

@wwwillchen wwwillchen force-pushed the i225 branch 6 times, most recently from f934030 to d2b0560 Compare May 17, 2024 06:55
@wwwillchen wwwillchen requested a review from richard-to May 17, 2024 16:59
richard-to
richard-to approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwillchen wwwillchen merged commit f644949 into google:main May 17, 2024
3 checks passed
@wwwillchen wwwillchen deleted the i225 branch May 17, 2024 18:05
This was referenced May 18, 2024
Merged
Merged
@n0mer n0mer mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure CSP and Trusted Types
2 participants
@wwwillchen @richard-to