Update hot reloading logic in execute_module.py #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. LGTM, but could you add a test case to mesop/mesop/cli/execute_module_test.py Line 16 in 5457ce5 |
This change separates the hot reloading logic for the mesop module and external app modules. Before this fix, if the app module is outside of the mesop module, then changes to code in labs would not be reflected in the hot reload.
richard-to
force-pushed
the
hotreload-fix
branch
from
ba5343d to
3bf42b1
Compare
Sure thing. Added a test. |
wwwillchen
pushed a commit
to wwwillchen/mesop
that referenced
this pull request
Apr 23, 2024
This change separates the hot reloading logic for the mesop module and external app modules. Before this fix, if the app module is outside of the mesop module, then changes to code in labs would not be reflected in the hot reload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change separates the hot reloading logic for the mesop module and external app modules.
Before this fix, if the app module is outside of the mesop module, then changes to code in labs would not be reflected in the hot reload since the mesop directory is not also the app module.