Fix missing type hints for @content_component #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked @component again and that seems to work. It was only @content_component which was not showing the type hints. Not sure why removing the annotation made it so thecustom component's annotations showed up. Closes google#912
|
Ugh... |
|
I don't think removing the type annotations is the right solution. Take a look at how @component is implemented. I think we need TypeVar and use it as a param and return value. |
Yeah looks that way. I find those annotations a bit hard to read. But yeah updated it with the TypeVar stuff. Claude (er...Gemini) explained the usage well enough. |
wwwillchen
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked @component again and that seems to work. It was only @content_component which was not showing the type hints.
Not sure why removing the annotation made it so thecustom component's annotations showed up.
Before
After
Closes #912