Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move copy_current_request_context to ensure thread-safety #1076

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Move copy_current_request_context to ensure thread-safety #1076

merged 1 commit into from
Oct 30, 2024

Conversation

wwwillchen
Copy link
Collaborator

This should fix the error I was getting in websockets mode:

ValueError: <Token var=<ContextVar name='flask.request_ctx' at 0x102d56c50> at 0x1138dbac0> was created in a different Context

See: pallets/flask#5254

@wwwillchen wwwillchen requested a review from richard-to October 29, 2024 22:09
richard-to
richard-to approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏾

@wwwillchen wwwillchen merged commit 17e79ee into google:main Oct 30, 2024
6 checks passed
@wwwillchen wwwillchen deleted the fix-ws-conc branch October 30, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwillchen @richard-to