Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component renderer: querying web component children #1066

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fix component renderer: querying web component children #1066

merged 2 commits into from
Oct 28, 2024

Conversation

wwwillchen
Copy link
Collaborator

No description provided.

@wwwillchen wwwillchen requested a review from richard-to October 27, 2024 06:39
richard-to
richard-to approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Surprised, we haven't run into this issue earlier.

mesop/web/src/component_renderer/component_renderer.ts Show resolved Hide resolved
@wwwillchen wwwillchen merged commit ece9a6e into google:main Oct 28, 2024
2 of 3 checks passed
@wwwillchen wwwillchen deleted the wc-child branch October 28, 2024 04:31
@wwwillchen
Copy link
Collaborator Author

Interesting. Surprised, we haven't run into this issue earlier.

yeah, i'm a little surprised too, but it's a somewhat advanced use case where you need to have nested web components with a dynamic number of children to hit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwillchen @richard-to