Allow custom favicons #1062
Merged
Allow custom favicons #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If static folder is enabled, then we will check if there is a favicon.ico in the designated static folder. If it exists, we will use the user's favicon instead of the default. Also: - Moved the static folder functions to server_utils.py - Improved validation slightly for static URL paths - Updated docs with custom favicon example Closes google#563
wwwillchen
reviewed
Oct 27, 2024
mesop/server/server.py
Outdated
| static_url_path = get_static_url_path() | ||
| if static_folder and static_url_path: | ||
| print(f"Static folder enabled: {static_folder}") | ||
| else: |
There was a problem hiding this comment.
imo, I think it's a little spammy to print this out (in the disabled case). we should eventually move most/if not all of our print statements into proper logger statements #903, but for now we should avoid adding prints in the base/default cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If static folder is enabled, then we will check if there is a favicon.ico in the designated static folder. If it exists, we will use the user's favicon instead of the default.
Also:
Closes #563
For a future improvement, we can add more complete favicon support. See https://www.emergeagency.com/insights/detail/the-essentials-of-favicons/