Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn (server) error box into a more standard dialog UI #1025

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Oct 11, 2024

  • Dialog provides a more standard UI compared to the somewhat strange fullscreen error box (it's easier to dismiss it and it's clearer from the overlay that there's, potentially, still UI that you can interact with).
  • Stop automatically hiding the error UI if there's no more errors in the next render; instead we will close the previous error dialog if there's a new error.
    • The problem with the previous approach of automatically hiding is that if you're streaming a response, the first chunk could through an error, but the second chunk might not, which results in a flash of the error UI even though the error is still in the code.

@wwwillchen wwwillchen changed the title Wrap error box in a dialog Turn (server) error box into a more standard dialog UI Oct 11, 2024
@wwwillchen wwwillchen requested a review from richard-to October 11, 2024 08:26
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. This is definitely more intuitive than the previous behavior.

@wwwillchen wwwillchen merged commit 01d2616 into google:main Oct 11, 2024
6 checks passed
@wwwillchen wwwillchen deleted the error-dialog branch October 11, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants