Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where multiple select values could not be initialized. #1013

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

richard-to
Copy link
Collaborator

Drive by adjustments:

  • Add appearance property to select
  • Update autocomplete/input/textarea/select to use outline appearance.

Closes #681

Drive by adjustments:

- Add appearance property to select
- Update autocomplete/input/textarea/select to use outline appearance.

Closes google#681
Copy link
Collaborator

@wwwillchen wwwillchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment on possible bug in equality check

mesop/components/select/select.ts Outdated Show resolved Hide resolved
@richard-to richard-to merged commit 4c32c42 into google:main Oct 4, 2024
6 checks passed
@richard-to richard-to deleted the select-multiple branch October 26, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't initialize me.select with multiple values
2 participants