Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HeapDict implementation with better docstrings and type hints #10

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

GiraldoNainggolan
Copy link

This PR improves the HeapDict implementation by:

  • Adding explicit type hints for better code clarity.
  • Refactoring get_result() to use dictionary comprehension.
  • Improving docstrings for better documentation.

These changes enhance readability and maintainability without altering functionality.

Copy link

google-cla bot commented Feb 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@GiraldoNainggolan
Copy link
Author

This PR improves the HeapDict implementation by:

Adding explicit type hints for better code clarity.
Refactoring get_result() to use dictionary comprehension.
Improving docstrings for better documentation.
These changes enhance readability and maintainability without altering functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants