Add support for older versions of CMake.#95
Merged
twifkak merged 4 commits intogoogle:mainfrom Jul 8, 2021
Merged
Conversation
Change cmake_minimum_required to 3.1 (earliest I could easily test) and update the README to specify CMAKE_INSTALL_LIBDIR=lib and CMAKE_INSTALL_BINDIR=bin, which it seems only became the default somewhere between CMake 3.11 and 3.15 inclusive.
banaag
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change cmake_minimum_required to 3.1 (earliest I could easily test) and update
the README to specify CMAKE_INSTALL_LIBDIR=lib and CMAKE_INSTALL_BINDIR=bin,
which it seems only became the default somewhere between CMake 3.11 and 3.15
inclusive.
/cc @cpapazian