cstdatomic problem with Debian

[cmumford]

Original issue 3 created by jorlow@chromium.org on 2011-05-10T14:03:43.000Z:

SVN r27.

I am on Debian unstable (as of today) and its default GCC version is
4.6.0. Doing "make" results in:

./port/port_posix.h:14:22: fatal error: cstdatomic: No such file or
directory

It seems that cstdatomic was renamed to atomic in newer GCC versions.
Replacing cstdatomic include with atomic include in the header worked
for me.

[cmumford]

Comment #1 originally posted by dr.jeff.foster on 2011-05-12T21:13:20.000Z:

I see the same thing on g++ (Ubuntu/Linaro 4.5.2-8ubuntu4) 4.5.2.

[cmumford]

Comment #2 originally posted by tfarina@chromium.org on 2011-05-17T21:09:22.000Z:

Yes, same thing here too with g++ 4.5.2.

[cmumford]

Comment #3 originally posted by tfarina@chromium.org on 2011-05-17T21:11:06.000Z:

The workaround of Jeremy worked for me.

[cmumford]

Comment #4 originally posted by tfarina@chromium.org on 2011-05-22T18:05:37.000Z:

<empty>

[cmumford]

Comment #5 originally posted by wmorgan.masanjin on 2011-06-19T21:43:01.000Z:

Here is a patch for this issue I've been using in my ruby bindings (https://github.com/wmorgan/leveldb-ruby):

--- cut here ---

--- a/leveldb/port/port_posix.h
+++ b/leveldb/port/port_posix.h
@@ -7,11 +7,20 @@
 #ifndef STORAGE_LEVELDB_PORT_PORT_POSIX_H_
 #define STORAGE_LEVELDB_PORT_PORT_POSIX_H_

+#define GCC_VERSION (__GNUC__ * 10000 \
+                      + __GNUC_MINOR__ * 100 \
+                      + __GNUC_PATCHLEVEL__)
 #include <endian.h>
 #include <pthread.h>
 #include <stdint.h>
 #include <string>
+
+#if GCC_VERSION > 40500 // check for GCC > 4.5
+#include <atomic>
+#else
 #include <cstdatomic>
+#endif // if GCC_VERSION > 40500
+
 #include <cstring>

 namespace leveldb {
--- cut here ---

[cmumford]

Comment #6 originally posted by dgrogan@chromium.org on 2011-06-21T01:20:02.000Z:

Great. So, 40500 still uses cstdatomic?

[cmumford]

Comment #7 originally posted by ashoemaker on 2011-06-24T08:35:44.000Z:

Looking at the gcc source, ≥ 4.5.0 has , while 4.4.x has . The version check could be:

#if GNUC >= 4 && GNUC_MINOR >= 5
#include
#else
#include
#endif

[cmumford]

Comment #8 originally posted by ashoemaker on 2011-07-02T06:18:50.000Z:

Verified fixed in r36.

[cmumford]

Comment #9 originally posted by gabor@google.com on 2011-07-19T23:45:42.000Z:

Marking this as verified due to Comment 8.

[cmumford]

Comment #10 originally posted by google@madler.net on 2012-02-18T23:34:40.000Z:

This:

#if GNUC >= 4 && GNUC_MINOR >= 5

will fail when GNUC gets to 5. Versions 5.0 to 5.4, 6.0 to 6.4, etc. will not pass the test. Either calculate the version number:

#define GCC_VER (GNUC-0 * 100 + GNUC_MINOR-0)

and compare that against 405, or check for the 5.0 and greater case:

#if GNUC-0 >= 5 || (GNUC-0 == 4 && GNUC_MINOR-0 >= 5)