Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Structural schemas for all the sources we intend to include in release/1 #824

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Structural schemas for all the sources we intend to include in release/1 #824

merged 1 commit into from
Apr 16, 2020

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Apr 14, 2020 •
edited
Loading

Helps with #614.

Proposed Changes

  • Create structural schemas for the sources that we intend to include in release/1.
    • This is a prerequisite for serving multiple versions of the same CRD.

Release Note

`CloudAuditLogsSource`, `CloudPubSubSource`, `CloudSchedulerSource`, 
and `CloudStorageSource` will aggressively remove unknown fields.

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Apr 14, 2020
@Harwayne
Copy link
Contributor Author

/test pull-google-knative-gcp-integration-tests

@Harwayne Harwayne mentioned this pull request Apr 14, 2020
Merged
@Harwayne
Copy link
Contributor Author

This is ready for review.

grantr
grantr approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2c36764 into google:master Apr 16, 2020
@Harwayne Harwayne deleted the sources-structural-yaml branch April 16, 2020 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grantr grantr grantr approved these changes

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@grantr grantr

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harwayne @knative-prow-robot @grantr @googlebot