-
Notifications
You must be signed in to change notification settings - Fork 74
Implement Istio http policy binding controller #656
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yolocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @nachocano |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yolocs made an initial pass, added a few nits.
The code is really neat!
pkg/reconciler/security/istio/httppolicybinding/resources_test.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/security/istio/httppolicybinding/httppolicybinding_test.go
Outdated
Show resolved
Hide resolved
The following is the coverage report on the affected files.
|
/lgtm Thanks for adding this @yolocs!!! Looking forward to seeing this in action!!! |
Fixes #595
Changes
HTTPPolicy
to IstioRequestAuthentication
andAuthorizationPolicy
RequestAuthentication
validates JWTsAuthorizationPolicy
checks request metadataMeaningful changes are at:
pkg/reconciler/security/istio
Release Note
Docs