This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Revert "Always pass upgrade test (#2059)" #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dc07ee0.
google-cla
bot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhongduo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
zhongduo
force-pushed
the
reenable-upgrade-test
branch
3 times, most recently
from
60eaf21
to
6314035
Compare
|
/test pull-google-knative-gcp-upgrade-tests |
zhongduo
force-pushed
the
reenable-upgrade-test
branch
from
6314035
to
6da2285
Compare
zhongduo
force-pushed
the
reenable-upgrade-test
branch
from
6da2285
to
8e0a7c5
Compare
|
/retest |
|
/lgtm |
|
/unhold |
|
/retest |
zhongduo
pushed a commit
to zhongduo/knative-gcp
that referenced
this pull request
Jan 14, 2021
* Revert "Always pass upgrade test (google#2059)" This reverts commit dc07ee0. * Use git tag without major version in master to get latest tag
knative-prow-robot
pushed a commit
that referenced
this pull request
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit dc07ee0.
Part of #2060