Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Webhook has only namespaced Secret permissions, rather than cluster-w… #2025

Merged

Conversation

Harwayne
Copy link
Contributor

Proposed Changes

  • Webhook has only namespaced Secret permissions, rather than cluster-wide.

Release Note

Webhook no longer has Cluster-wide Secret permissions. Now the Webhook's Secret permissions are restricted to the `cloud-run-events` namespace.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Dec 28, 2020
@Harwayne Harwayne changed the title [WIP] Webhook has only namespaced Secret permissions, rather than cluster-w… Webhook has only namespaced Secret permissions, rather than cluster-w… Dec 28, 2020
Copy link
Contributor

@danyinggu danyinggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot merged commit 6ae51c6 into google:master Dec 29, 2020
@Harwayne Harwayne deleted the webhook-namespaced-secrets-rbac branch December 29, 2020 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants