-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
f8946cf
to
977fc4a
Compare
Note: the failing tests are expected to fail due to this change. |
977fc4a
to
1f90308
Compare
0771683
to
b82fb7d
Compare
c978364
to
b82fb7d
Compare
b82fb7d
to
5ca6262
Compare
I'm not sure what to do about these regex:
|
86df846
to
8c2c32c
Compare
I think the lint check is incorrect. It identifies a part of the word instead of the entire word. |
8c2c32c
to
1609e4e
Compare
/retest |
df2aa53
to
96094b4
Compare
96094b4
to
03ee635
Compare
/lgtm |
/hold waiting for a review from @Harwayne |
namespace: cloud-run-events | ||
failurePolicy: Fail | ||
namespace: events-system | ||
failurePolicy: Ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to be in this PR? I actually like the change, but am not sure we want to include it in this large renaming PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we have it here is that we couldn't get past the webhook issue when testing without it. I can also move it to a separate PR, if preferable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexandraRoatis, Harwayne, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
- cloud-run-events-probe -> events-system-probe - cloud-run-events-example -> events-system-example - cloud-run-events-controller -> events-system-controller - cloud-run-events-broker -> events-system-broker - cloud-run-events-webhook -> events-system-webhook - cloud-run-events-source-observer -> events-system-source-observer - cloud-run-events-pubsub-* -> events-pubsub-* - cloud-run-events-* to events-system-* (non-namespace & not service accounts) - cloud-run-events -> events-system (namespace only) - test-cloud-run-events -> test-events-system
This is done to avoid race conditions where the config maps cannot be created due to this validation policy.
03ee635
to
cbc8531
Compare
Merge seemed to still be blocked so I did a rebase to see if it is finally triggered after. /assign @zhongduo |
/lgtm |
/retest |
@AlexandraRoatis: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This reverts commit 2435e8c.
This reverts commit 2435e8c.
Moving to a brand-agnostic namespace.
Proposed Changes
cloud-run-events
namespace and prefix withevents-system
.Release Note