-
Notifications
You must be signed in to change notification settings - Fork 74
Flip storage version of CloudBuildSource to v1 #1797
Flip storage version of CloudBuildSource to v1 #1797
Conversation
3b0cb5c
to
95eacf0
Compare
@eclipselu Have you ran the pre-install job and verified it still works after the change of cluster role? |
/lgtm |
Test done:1. Install release-0.17 and create a CloudBuildSource CO.
k apply -f docs/examples/cloudbuildsource/cloudbuildsource.yaml
k get customresourcedefinition.apiextensions.k8s.io/cloudbuildsources.events.cloud.google.com -o=jsonpath='{.status.storedVersions}'
# ["v1beta1"] 2. Upgrade to release-0.18
ko apply -f config/pre-install/v0.18.0
k get customresourcedefinition.apiextensions.k8s.io/cloudbuildsources.events.cloud.google.com -o=jsonpath='{.status.storedVersions}'
# ["v1beta1"]
k get cloudbuildsource -o yaml
# should output the CO
k get pods -l app=storage-version-migration-knative-gcp -n cloud-run-events
NAME READY STATUS RESTARTS AGE
storage-version-migration-knative-gcp-fsxvk 0/1 Completed 0 61m 3. Flip CloudBuildSource storage version to v1
ko apply -f config/pre-install/v0.19.0
k get customresourcedefinition.apiextensions.k8s.io/cloudbuildsources.events.cloud.google.com -o=jsonpath='{.status.storedVersions}'
# ["v1"]
k get cloudbuildsource -o yaml
# should output the CO
k get pods -l app=storage-version-migration-knative-gcp-v0-19-0 -n cloud-run-events
NAME READY STATUS RESTARTS AGE
storage-version-migration-knative-gcp-v0-19-0-qswc8 0/1 Completed 0 56m SummaryThis means that we can successfully upgrade from v0.18.0 -> v0.19.0, even if user previously upgraded to v0.18.0 from v0.17.0. The last migration job should not conflict with migration jobs in the previous versions (e.g. v0.18.0) |
95eacf0
to
1f8af73
Compare
1f8af73
to
98860ee
Compare
98860ee
to
c5e3320
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, danyinggu, eclipselu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1610
Proposed Changes
Release Note
Docs