This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Fix wrong status message by changing %w to %v.
#1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experiment shows that `%w` does not invoke the `Error() string` method
that the error type provides for proper struct formatting. When using
it in status message or logger, we will get sth like:
```
- lastTransitionTime: "2020-09-09T13:23:24Z"
message: 'Failed to verify Pub/Sub topic exists: %!w(*status.Error=&{0xc0024ffe60})'
reason: TopicVerificationFailed
```
After the fix, it will show as:
```
- lastTransitionTime: "2020-09-09T14:13:41Z"
message: |-
Failed to verify Pub/Sub topic exists: rpc error: code = Unauthenticated desc = transport: oauth2: cannot fetch token: 400 Bad Request
Response: {"error":"invalid_grant","error_description":"Invalid JWT Signature."}
reason: TopicVerificationFailed
```
google-cla
bot
added
the
cla: yes
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grac3gao, zhongduo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following jobs failed:
Automatically retrying due to test flakiness... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment shows that
%wdoes not invoke theError() stringmethodthat the error type provides for proper struct formatting. When using
it in status message or logger, we will get sth like:
After the fix, it will show as:
Fixes #1672
Proposed Changes
%wwith%vin status message and loggingRelease Note
Docs