Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Flip storage versions of Sources, topic, pullSubscription to v1 and add migration tool #1644

Merged
merged 6 commits into from
Aug 27, 2020

Conversation

danyinggu
Copy link
Contributor

@danyinggu danyinggu commented Aug 27, 2020

Fixes #1482

Proposed Changes

  • Flip storage versions of all Sources except CloudBuildSource, Topic and pullSubscription from v1beta1 to v1.
  • Add migration tool for all above resources.
  • There will be a separate PR to flip served bits of deprecated v1alpha1 resources as this is a separate issue.

Release Note

Change storage versions of all below resources from v1beta1 to v1:
            - "cloudauditlogssources.events.cloud.google.com"
            - "cloudpubsubsources.events.cloud.google.com"
            - "cloudstoragesources.events.cloud.google.com"
            - "cloudschedulersources.events.cloud.google.com"
            - "pullsubscriptions.internal.events.cloud.google.com"
            - "topics.internal.events.cloud.google.com"

action required: You must run pre-install job prior to upgrading to get these resources to v1 API.
ko apply -f config/pre-install/v0.18.0/

Docs

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Aug 27, 2020
@danyinggu
Copy link
Contributor Author

The size of this PR is already huge. We will flip served bits of v1alpha1 Sources and Channel as a follow-up, as this is a separate issue from changing storage bits of v1.
I created a separate issue here #1645 to keep track.

@danyinggu danyinggu changed the title Flip storage versions of Sources, topic, pullSubscription and add migration tool Flip storage versions of Sources, topic, pullSubscription to v1 and add migration tool Aug 27, 2020
@nachocano
Copy link
Member

I think we need to add a new artifact to our release, so that we include the migration bits...
I think eventing does so, maybe you can do it in a follow up?

@nachocano
Copy link
Member

/lgtm
/approve

I think we need something like: knative/eventing#3928
We can double check with @chizhg

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danyinggu, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nachocano
Copy link
Member

/lgtm

@capri-xiyue
Copy link
Contributor

/lgtm

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-integration-tests:

test/e2e.TestChannelChain/Channel-messaging.cloud.google.com/v1beta1
test/e2e.TestChannelChain
test/e2e.TestEventTransformationForSubscription/Channel-messaging.cloud.google.com/v1alpha1
test/e2e.TestEventTransformationForSubscription

@knative-prow-robot knative-prow-robot merged commit 18e6314 into google:master Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make v1 the storage version for all sources (except CloudBuildSource)
5 participants