Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Handle malformed replies in delivery processor #1419

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

yolocs
Copy link
Member

@yolocs yolocs commented Jul 8, 2020

Related to #1362
Hopefully this could provide some insight for some of the test flakiness.

Proposed Changes

Release Note

Malformed replies will be treated as error (instead of being silently ignored).

Docs

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jul 8, 2020
@grac3gao-zz
Copy link
Contributor

/lgtm
/hold in case other reviewer may have comments

@yolocs
Copy link
Member Author

yolocs commented Jul 10, 2020

/unhold

@yolocs
Copy link
Member Author

yolocs commented Jul 10, 2020

/retest

9 similar comments
@yolocs
Copy link
Member Author

yolocs commented Jul 10, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs yolocs closed this Jul 13, 2020
@yolocs yolocs reopened this Jul 13, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/handler/processors/deliver/processor.go 78.1% 79.5% 1.4

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

4 similar comments
@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 13, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 14, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 14, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Jul 14, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit d37af7b into google:master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants