This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Limit the values of event_type in Broker metrics #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With custom events, these values can be any string which impacts the overall cardinality of the metrics. We're instead going to limit these values to be any GCP event type, as defined by the "com.google.cloud" prefix. And include some values used in some E2E tests. All other event types will default to being labeled as "custom" Trigger metrics will continue to label filter type as "any" if there is no filter type defined.
nachocano
reviewed
Jun 25, 2020
nachocano
reviewed
Jun 25, 2020
nachocano
reviewed
Jun 25, 2020
|
Is there anything preventing a user from creating custom event types with a com.google.cloud prefix? |
Harwayne
reviewed
Jun 25, 2020
|
/retest
…On Thu, Jun 25, 2020 at 9:06 PM Knative Prow Robot ***@***.***> wrote:
@zargarpur <https://github.com/zargarpur>: The following tests *failed*,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-google-knative-gcp-wi-tests f8fa129
<f8fa129>
link
<https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/google_knative-gcp/1352/pull-google-knative-gcp-wi-tests/1276354892973215747> /test
pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-integration-tests f8fa129
<f8fa129>
link
<https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/google_knative-gcp/1352/pull-google-knative-gcp-integration-tests/1276363826769432576> /test
pull-google-knative-gcp-integration-tests
Full PR test history
<https://gubernator.knative.dev/pr/google_knative-gcp/1352>. Your PR
dashboard <https://gubernator.knative.dev/pr/zargarpur>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1352 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD65DGREQVKMUGR76B2C3DRYQNF5ANCNFSM4OI2QWIQ>
.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, zargarpur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ian-mi
reviewed
Jun 26, 2020
|
/hold cancel |
|
/hold |
|
/hold |
zargarpur
changed the title
|
/lgtm |
|
/hold cancel |
|
The following is the coverage report on the affected files.
|
|
The following jobs failed:
Job pull-google-knative-gcp-wi-tests expended all 3 retries without success. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With custom events, these values can be any string which impacts the overall cardinality of the metrics.
We're instead going to limit these values to be any GCP event type, as defined by the "google.cloud" prefix. And include some values used in some E2E tests. All other event types will default to being labeled as "custom"
Trigger metrics will continue to label filter type as "any" if there is no filter type defined.