Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Use the new PullSubscription and Topic CRD #1050

Merged
merged 30 commits into from
May 14, 2020

Conversation

Harwayne
Copy link
Contributor

Helps with #905.

Proposed Changes

  • Channels and Sources use the PullSubscription and Topic CRDs in the internal.events.cloud.google.com API group.

Release Note

Channels and Sources use the `PullSubscription` and `Topic` CRDs in the `internal.events.cloud.google.com` API group.

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label May 12, 2020
@Harwayne
Copy link
Contributor Author

/retest

@Harwayne
Copy link
Contributor Author

/retest

2 similar comments
@Harwayne
Copy link
Contributor Author

/retest

@Harwayne
Copy link
Contributor Author

/retest

Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Harwayne for doing the grungy rename here!

pkg/reconciler/events/scheduler/scheduler_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/intevents/v1alpha1/pullsubscription_conversion.go Do not exist 82.6%
pkg/apis/intevents/v1alpha1/topic_conversion.go Do not exist 78.3%
pkg/apis/messaging/v1alpha1/channel_conversion.go Do not exist 93.9%
pkg/reconciler/events/auditlogs/controller.go 100.0% 92.3% -7.7
pkg/reconciler/events/build/controller.go 100.0% 90.0% -10.0
pkg/reconciler/events/pubsub/controller.go 100.0% 90.9% -9.1
pkg/reconciler/events/scheduler/controller.go 100.0% 92.3% -7.7
pkg/reconciler/events/storage/controller.go 100.0% 92.3% -7.7
pkg/reconciler/messaging/channel/channel.go 79.6% 79.9% 0.3
pkg/reconciler/messaging/channel/controller.go 100.0% 92.3% -7.7

@knative-prow-robot knative-prow-robot merged commit 609c5f6 into google:master May 14, 2020
@Harwayne Harwayne deleted the 905-move-to-new-crds branch May 15, 2020 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants