Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Move to the GenReconciler #557

Closed
nachocano opened this issue Feb 19, 2020 · 3 comments
Closed

Move to the GenReconciler #557

nachocano opened this issue Feb 19, 2020 · 3 comments
Assignees
@nlopezgi
Labels
area/sources kind/cleanup Internal cleanup (tech debt, etc) without customer impact, but affects developer velocity. priority/2 Nice to have feature but doesn't block current release defined by release/* release/1
Milestone
v0.14.0-M1

Comments

@nachocano
Copy link
Member

Problem
Leverage the new genreconciler funcionality enabled in knative/pkg to reduce boilerplate reconciler code.

Persona:
Contributor

Exit Criteria
Using the new genReconciler framework

Time Estimate (optional):
1w

Additional context (optional)
This is a sensitive change that should be done in stages (one reconciler at a time).
Preferably once we have all our e2e tests in place #511.
@nachocano nachocano added the kind/feature-request New feature or request label Feb 19, 2020
@nachocano nachocano added this to the v0.14.0-M1 milestone Feb 19, 2020
@nachocano nachocano added kind/cleanup Internal cleanup (tech debt, etc) without customer impact, but affects developer velocity. priority/2 Nice to have feature but doesn't block current release defined by release/* and removed kind/feature-request New feature or request labels Mar 2, 2020
@nachocano
Copy link
Member Author

/assign @nachocano

@nachocano nachocano assigned nlopezgi and unassigned nachocano Mar 4, 2020
@nachocano
Copy link
Member Author

Some examples here:

knative/eventing#2540
knative/eventing#2541
knative/eventing#2543

Things to watch out for is the finalizers part. I think there is a new FinalizeKind method. There is an example in the Subscription controller.
Also some of the warning events that we were emitting won't be emitted anymore. We will have to update multiple UTs.
In order of priority I think I would do:

  • Sources first (all the ones within the events package). Can be done in multiple PRs.
  • Channel
  • Topic
  • and finally PullSubscription (this might require some more work as I added a base thing for KEDA or non-KEDA)

This was referenced Mar 5, 2020
Merged
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Merged
Merged
Merged
@nachocano
Copy link
Member Author

This was fixed by all the referenced PRs.
Thanks @nlopezgi !!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nlopezgi nlopezgi

Labels
area/sources kind/cleanup Internal cleanup (tech debt, etc) without customer impact, but affects developer velocity. priority/2 Nice to have feature but doesn't block current release defined by release/* release/1
Projects
None yet
Milestone
v0.14.0-M1
Development

No branches or pull requests
3 participants
@grantr @nlopezgi @nachocano