-
Notifications
You must be signed in to change notification settings - Fork 74
E2E test: Each source with PubSub backed channel #511
Comments
/assign @nlopezgi |
We need this e2e tests, sending from one of our Sources to a Broker backed by PubSub channel, and receiving on the Kn Service on the other end. In order of priority:
I think each of the tests can be committed in their own PR, and once we have all of them checked, we can close this issue... |
Some docs to look at on how to run e2e tests... TL'DR: either submit a WIP PR and PROW will run it for you. Or you can run some scripts locally to upload the tests images, and then run your particular test in your own cluster (will probably be faster for development, unless you skip all the other ones in the WIP PR) A bunch of the stuff here https://github.com/google/knative-gcp/blob/master/test/e2e/test_broker_pubsub.go can be reused... knative-gcp/test/e2e/test_broker_pubsub.go Line 117 in 67cc0dc
For our new tests, we need the sender to be an actual Source. For an example of a Source, you can see knative-gcp/test/e2e/test_pubsub.go Line 67 in 67cc0dc
There are examples for the other Sources as well in the same package. @chizhg is our guy when it comes to e2e, so he will help out with the review (and maybe with some suggestions on how to properly refactor things out) |
We need to test each source with PubSub backed channel to avoid breaking CRfA. This could be done in knative-gcp repo or CloudRun repo. I would prefer knative-gcp repo so that issues are caught early at source.
The text was updated successfully, but these errors were encountered: