This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Merged
Conversation
Signed-off-by: Manish Kumar <manishjpiet@gmail.com>
Contributor
Author
|
CC @qiwzhang |
qiwzhang
reviewed
Dec 16, 2020
BUILD
Outdated
| "jwt_verify_lib/check_audience.h", | ||
| "jwt_verify_lib/jwks.h", | ||
| "jwt_verify_lib/jwt.h", | ||
| "jwt_verify_lib/simple_lru_cache.h", |
Contributor
There was a problem hiding this comment.
- Please make this a separate cc_library,
- put the two header files into a separate include folder, simple_lru_cache/ folder
- move all test.cc file into test/ folder
Folder org:
jwt_verify_lib/
simple_lru_cache/
src/
test/
Signed-off-by: Manish Kumar <manishjpiet@gmail.com>
nareddyt
approved these changes
Dec 16, 2020
qiwzhang
suggested changes
Dec 16, 2020
simple_lru_cache/simple_lru_cache.h
Outdated
| #include "absl/container/flat_hash_map.h" // for hash<> | ||
|
|
||
| namespace google { | ||
| namespace jwt_verify { |
Contributor
There was a problem hiding this comment.
please change namespace from jwt_verify to simple_lru_cache thanks
Signed-off-by: Manish Kumar <manishjpiet@gmail.com>
qiwzhang
approved these changes
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manish Kumar manishjpiet@gmail.com
Added LRU cache.
Ref : envoyproxy/envoy/14341