Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support for Travis CI #784

Closed
wants to merge 4 commits into from

Conversation

mckunda
Copy link

@mckunda mckunda commented Mar 17, 2020

DO NOT MERGE UNTIL SECURITY PROBLEMS ARE RESOLVED!

Fixes #734

This PR is an attempt to provide Windows builds as proposed at #734

Prerequisites:

Build:

refreshenv
cmake . -B build -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -G "Unix Makefiles"
cmake --build build --target jsonnetfmt
cmake --build build --target jsonnet
cmake --build build --target run_tests

.travis.yml is modified so that archives with executables can be found at directory upload

Problems:

  • -pedantic leads to compiler errors since MSVC libraries use language extensions
  • -std=c++11 leads to compiler errors
  • unable to run setup.py
  • unable to run regression tests (CMake target run_tests, filetest_suite/run_tests.sh)
  • Secrets ARE NOT obfuscated in Travis Windows builds (means this PR is unable to merge)

Any support is appreciated.

@Toilal
Copy link

Toilal commented Jan 13, 2021

https://github.com/mcovalt/jsonnetbin just works and seems damn simple. Please take a look at this repository and include the setup.py configuration inside the official project.

@johnbartholomew
Copy link
Collaborator

Hi! Thanks for your contribution, and your patience!

The Travis CI build unfortunately stopped working a while ago (I'm not sure exactly when), so this PR in its current form is no longer viable. However we now GitHub actions workflow to replace it, so hopefully we can set up something that will satisfy #734

https://github.com/mcovalt/jsonnetbin just works and seems damn simple. Please take a look at this repository and include the setup.py configuration inside the official project.

That repository is not accessible to me - perhaps the author has deleted it or made it private. I see they left a comment #734 (comment) that gives a hint at what they did though. I also see you (@Toilal) have a package derived from jsonnetbin at https://github.com/Toilal/python-jsonnet-binary

@mckunda
Copy link
Author

mckunda commented Mar 4, 2024

Ok, closing as irrelevant.

@mckunda mckunda closed this Mar 4, 2024
@johnbartholomew
Copy link
Collaborator

@mckunda FYI, if you are still interested in Windows support for the Python module, I am hoping that #1137 will get us significantly closer to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish binary releases for Windows
4 participants