CMake build and test. #303
Conversation
Not supported yet: * Windows * Emscripten * Compilers other than GCC and Clang.
| @@ -0,0 +1,67 @@ | |||
| # libjsonnet | |||
|
|
|||
| # Remember to update Bazel and Makefile builds when updating this list! | |||
There was a problem hiding this comment.
and MANIFEST.in and setup.py :(
|
This looks ok, except it seems your build test is failing on mac? I'd like to try it out myself, but haven't got time right now. In particular, is there enough feature parity to remove the handwritten makefiles... |
|
Oh there is emscripten, as you said. |
|
CMake could easily take over everything the handwritten makefile does now. The Python build be a CMake target, where CMake generates setup.py/MANIFEST.in via a template using the LIB_SOURCES variable in I'd prefer to implement Python and Emscripten builds in a follow-up PR to keep the size manageable, but I could build it into this one if you'd like. I think Travis is failing on Linux. I developed this on a Mac so at least the Mac build is green :). I have access to all three systems so I will troubleshoot it when I get a chance. |
* Download googletest at CMake generation time. This makes linking simpler and should fix the Linux Travis build. * Build the jsonnet standard library header (std.jsonnet.h) via CMake. Doing this in a cross-platform fashion required a small C++ utility to generate the code.
|
I fixed the issue with Linux, Travis should work now (I'm not sure why it hasn't re-run). I also added a cross-platform std.jsonnet.h generator. I noticed some functionality in run_tests.sh. I think I can implement that in CMake. Shell scripts won't run on Windows so I'll want to port that eventually. |
CMake will compile targets without header files listed as files, but it won't recompile when changes are made unless the files are listed as dependencies.
|
There is one script that makes sure jsonnet outputs "true" (or matches the golden file if provided) and another script that makes sure jsonnet fmt does not change the jsonnet file (or matches the golden file if provided). |
|
Hey, should I have merged this? |
|
Yes, I think this was ready to go out. I'll resolve merge conflicts and give it a quick test in the next week and let you know when it's ready. |
|
Awesome, thanks for coming back to it after all this time. |
|
The code looks good overall, but tests are failing after the pulling in 8 months-worth of changes. I'll ping this thread when I have it working again. |
|
The error was on my end. This is ready to go. |
|
Thanks! |
Add support for building and testing with CMake. This is necessary for future MSVC support (#300).
Not supported yet: