-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For easily using jsonnet in test. #208
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
RUN apt-get update && \ | ||
apt-get install -y git build-essential autoconf libtool make | ||
|
||
# Install protoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protoc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
btw, I updated the CLA info, would like to know how to trigger another CLA check. Thanks! |
I manually verified you signed the CLA, so please rebase and I'll merge. |
Hi @sparkprime , I already rebased, but looks nothing happened. Anything I should do to disable "cla:no"? Thanks! Best Regards, |
Sorry I meant squash to one commit as there's no point having that intermediate state in the core repo :) That might make the cla:no go away because it will trigger the bot to re-check but if not I can merge it anyway as I manually validated your CLA status. |
CLAs look good, thanks! |
Looks it works. Thanks, @sparkprime ! Would you take another look? |
My use case is: based on the built image, I can add maven and corresponding Java staff into it, and then I can use the command line to generate json / protobuf for config files, like gcl did.