fix: Clean build artifacts for successful repackage#1224
Merged
johnbartholomew merged 1 commit intoMar 15, 2025
Conversation
The clean target in the Makefile wasn't removing all the temporary build files and directories, specifically build and jsonnet.egg-info. This caused a problem when trying to repackage the source for Debian. For more details about the problem, see the following bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1047367 This patch simply adds these to the clean command, ensuring a truly clean build environment, which is required by Debian policy. This change isn't just for Debian; it will also benefit other distributions that package Jsonnet, as it ensures a consistent and reliable build process across all platforms.
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clean target in the Makefile wasn't removing all the temporary build files and directories, specifically build and jsonnet.egg-info. This caused a problem when trying to repackage the source for Debian. For more details about the problem, see the following bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1047367
This patch simply adds these to the clean command, ensuring a truly clean build environment, which is required by Debian policy. This change isn't just for Debian; it will also benefit other distributions that package Jsonnet, as it ensures a consistent and reliable build process across all platforms.