break :: into :, : anywhere in a slice #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +49,14 @@ local arrCases = [ | |||
| output: arr, | |||
| }, | |||
| { | |||
| input: arr[1::], | |||
There was a problem hiding this comment.
It's not possible to run the formatter on these tests as it denatures the test.
There was a problem hiding this comment.
Yeah there are several cases of that already, they should have a .fmt.golden file to hold the output of formatting those files (because they do not format to themselves). If I accidentally broke the test, please fix it ;)
There was a problem hiding this comment.
You'll want to run ./refresh_fmt_golden.sh on this one.
There was a problem hiding this comment.
Ah ok. Updated .fmt.golden. It looks like you made some changes but manually reverted anything that would have modified the tests so lgtm.
17c59ac#diff-5dd5fae04796372f66a075da6ff11ffc
sparkprime
added a commit
that referenced
this pull request
Mar 1, 2016
break :: into :, : anywhere in a slice
This was referenced Nov 20, 2023
sbarzowski
added a commit
to sbarzowski/jsonnet
that referenced
this pull request
Jun 10, 2024
Before it would just crash
sbarzowski
added a commit
to sbarzowski/jsonnet
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#115