chore: add test for alias type

google · Dec 17, 2024 · c755d53 · c755d53
1 parent f97850f
commit c755d53
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/json_annotation/lib/src/json_value.dart b/json_annotation/lib/src/json_value.dart
@@ -12,7 +12,7 @@ class JsonValue {
   /// Optional values that can be used when deserializing.
   ///
   /// The elements of [aliases] must be either [String] or [int].
-  final Set<Object?> aliases;
+  final Set<Object> aliases;
 
   const JsonValue(this.value, {this.aliases = const {}});
 }
diff --git a/json_serializable/lib/src/enum_utils.dart b/json_serializable/lib/src/enum_utils.dart
@@ -216,7 +216,7 @@ List<Object?> _generateAliases({
       final targetTypeCode = typeToCode(targetType);
       throw InvalidGenerationSourceError(
         'The `JsonValue` annotation on `$targetTypeCode.${field.name}` aliases '
-        'should all be of type String, or int.',
+        'should all be of type String or int.',
         element: field,
       );
     }

diff --git a/json_serializable/test/json_serializable_test.dart b/json_serializable/test/json_serializable_test.dart
@@ -32,6 +32,7 @@ Future<void> main() async {
     jsonEnumTestReader,
     const JsonEnumGenerator(),
     expectedAnnotatedTests: {
+      'EnumAliasNotSupportType',
       'EnumValueIssue1147',
       'EnumValueNotAField',
       'EnumValueNotSupportType',

diff --git a/json_serializable/test/src/_json_enum_test_input.dart b/json_serializable/test/src/_json_enum_test_input.dart
@@ -5,6 +5,16 @@
 import 'package:json_annotation/json_annotation.dart';
 import 'package:source_gen_test/annotations.dart';
 
+@ShouldThrow(
+  'The `JsonValue` annotation on `EnumAliasNotSupportType.one` aliases should '
+  'all be of type String or int.',
+)
+@JsonEnum(alwaysCreate: true)
+enum EnumAliasNotSupportType {
+  @JsonValue('one', aliases: {#one})
+  one,
+}
+
 @ShouldGenerate(r'''
 // ignore: unused_element
 const _$EnumValueIssue1147EnumMap = {