Update Error Prone to 2.32.0 and only run it on JDK 17+. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_678295410
branch
8 times, most recently
from
648a21e
to
0efc210
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_678295410
branch
3 times, most recently
from
4d4f741
to
b6d4c6d
Compare
copybara-service
bot
force-pushed
the
test_678295410
branch
from
b6d4c6d
to
74a8315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Error Prone to 2.32.0 and only run it on JDK 17+.
Error Prone was actually not running on JDK 17+ at all due to profile activation only looking at the first of the JDK version ranges apparently. I don't know if that's a bug, but it seemed to be a valid version range specification according to https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html.
The
-Jflags were also not actually being passed to the compiler, but that wasn't required on JDK 11, so nothing appeared to be broken.forkneeds to be set totrueto pass the-Jflags. Seehttps://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerArgs:
RELNOTES=n/a