Skip to content

Fixed two issues with the SwiftName annotation #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Fixed two issues with the SwiftName annotation #2568

wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Sep 23, 2025 •
edited
Loading

Fixed two issues with the SwiftName annotation

  1. The annotation could be manually placed on a private interface. This is now an error
  2. When the annotation is added on the package level, the transpiler will add the annotation to the private interfaces which could cause a swift compiler error. This also prevents that.

@copybara-service copybara-service bot force-pushed the test_810623644 branch 2 times, most recently from 8e10ec2 to 498b5b7 Compare October 6, 2025 20:41
@copybara-service copybara-service bot changed the title Fixed SwiftName annotation being added to private interfaces in the j2objc transpiler Fixed two issues with the SwiftName annotation Oct 6, 2025
@copybara-service copybara-service bot closed this Oct 6, 2025
@copybara-service copybara-service bot deleted the test_810623644 branch October 6, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kokoro:run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants