Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version of protobuff_runtime.jar in J2ObjC 2.3 (cannot compile) #1019

Closed
sarsonj opened this issue Dec 19, 2018 · 3 comments
Closed

Wrong version of protobuff_runtime.jar in J2ObjC 2.3 (cannot compile) #1019

sarsonj opened this issue Dec 19, 2018 · 3 comments

Comments

@sarsonj
Copy link
Contributor

sarsonj commented Dec 19, 2018

Hi,

it looks like that there is older version (3.3) of protobuff runtime, than protobuff compiler itself (3.5.1). When used I got compilation errors like:

symbol: method setUnknownFieldsProto3(UnknownFieldSet)
/Users/sarsonj/Documents/work/ios/ttmonitor-common/protobuf/genjava/pb/Pb.java:28721: error: cannot find symbol
if (!parseUnknownFieldProto3(
^

After using JAR from protobuff 3.5.1, it works.

Thanks,

Jindrich

@antonio-cortes-perez
Copy link
Contributor

Hi,

The last few releases of J2ObjC were built with protobuf 3.5.1. I'll look into updating to the latest protobuf version for the next release.

Thanks,
Antonio.

@sarsonj
Copy link
Contributor Author

sarsonj commented Dec 19, 2018

Right, but the problem is, that protobuff compiler is 3.5.1, but protobuff runtime is 3.3.0:

$ j2objc_protoc --version
libprotoc 3.5.1

Info from protobuff_runtime.jar:

Bundle-SymbolicName: com.google.protobuf
Bundle-Vendor: Google
Bundle-Version: 3.3.0
Created-By: Apache Maven Bundle Plugin
Export-Package: com.google.protobuf;version="3.3.0"

So that the generated java doesn't compile according provided runtime.

Both j2objc_protoc and protobuff_runtime.jar taken from official zip file downloaded from j2objc - version 2.3 (j2objc-2.3.zip).

@sarsonj sarsonj changed the title Wrong version of protobuff_runtime.jar in J2Objc 2.3 (cannot compile) Wrong version of protobuff_runtime.jar in J2ObjC 2.3 (cannot compile) Dec 20, 2018
antonio-cortes-perez added a commit that referenced this issue Jan 3, 2019
	Change on 2018/12/28 by antoniocortes <[email protected]>

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=227129646
@antonio-cortes-perez
Copy link
Contributor

Fixed in 2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants