Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Closes: #1#5879

Open
nancyjain187 wants to merge 1 commit intogoogle:masterfrom
nancyjain187:improve-username-behavior
Open

Closes: #1#5879
nancyjain187 wants to merge 1 commit intogoogle:masterfrom
nancyjain187:improve-username-behavior

Conversation

@nancyjain187
Copy link

Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py.

Fixes #1 fixed error of isnumeric() function which works only on unicodes
#2 added checks for checking first letter of the name.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py.
@google-cla
Copy link

google-cla bot commented Aug 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Course3/Lab4: Usernames should always start with letters

1 participant