Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

I have finally fix the code!#32187

Open
Rainbugs wants to merge 1 commit intogoogle:masterfrom
Rainbugs:improve-username-behavior
Open

I have finally fix the code!#32187
Rainbugs wants to merge 1 commit intogoogle:masterfrom
Rainbugs:improve-username-behavior

Conversation

@Rainbugs
Copy link

@Rainbugs Rainbugs commented Aug 30, 2023

Fixes #2

It's a good idea to open an issue first for discussion.
I changed the isnumeric() to not isalpha()

  • Tests pass
  • Appropriate changes to README are included in PR

@google-cla
Copy link

google-cla bot commented Aug 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant