Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert key is not in Dynamic Attributes #144

Closed

Commits on Oct 8, 2015

  1. Assert key is not in Dynamic Attributes

    A changing key attribute (but not passed as the `key` parameter) could
    cause havoc. Force `key` to always be static.
    
    This is of particular interest to compile to iDOM build steps, since a
    runtime `attr(name, value)` would be impossible to catch:
    
    ```js
    var attrs = { key: 'key' };
    
    elementOpenStart('div');
    for (var name in attrs) {
        attr(name, attrs[name]);
    }
    elementOpenEnd('div');
    elementClose('div');
    ```
    jridgewell committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    e8a7632 View commit details
    Browse the repository at this point in the history