This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Exit early from onLayout if not changed & state is transitioning #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exiting early based solely on
changedwas causing issues as described in this PR #39. Removing the early exit entirely was causing theCollapsedMenuViewControllerto set the active tab translations before the collapse animation was started. This caused the animation not to run.Adding a check
mVisualState == TRANSITIONINGto this block prevents both issues. New tabs get laid out correctly as expected, and we don't set the position of the active tab while transitioning/animating.