Add vllm benchmark #10600
Open
Add vllm benchmark #10600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl648472759
branch
2 times, most recently
from
59aaeae
to
6362a8a
Compare
Hi, I was playing around with a vLLM benchmark and wanted to get your opinion on how to best deal with large files in benchmarks. The vLLM benchmark serves a model (facebook/opt-125m) and uses vLLM's own benchmark tooling to query it with a widely-used dataset (..). For development I just mounted the model and dataset into the container-under-test. But that seems impractical for CI/other devs. Should I embed the model files into the benchmark image? Is there another way you would prefer? Please don't do an actual review yet. Just wanted to get some early feedback. I still have to understand `metricsviz` and how to incorporate it. FUTURE_COPYBARA_INTEGRATE_REVIEW=#10512 from derpsteb:vllm-benchmark 1b9f8f3 PiperOrigin-RevId: 648472759
copybara-service
bot
force-pushed
the
test/cl648472759
branch
from
6362a8a
to
ba624b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vllm benchmark
Hi,
I was playing around with a vLLM benchmark and wanted to get your opinion on how to best deal with large files in benchmarks. The vLLM benchmark serves a model (facebook/opt-125m) and uses vLLM's own benchmark tooling to query it with a widely-used dataset (..). For development I just mounted the model and dataset into the container-under-test. But that seems impractical for CI/other devs.
Should I embed the model files into the benchmark image? Is there another way you would prefer?
Please don't do an actual review yet. Just wanted to get some early feedback. I still have to understand
metricsvizand how to incorporate it.FUTURE_COPYBARA_INTEGRATE_REVIEW=#10512 from derpsteb:vllm-benchmark 1b9f8f3