Update unsafe class defining to work on Java 17+ #1529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameb
reviewed
Aug 16, 2021
There was a problem hiding this comment.
Thanks @mcculls! In addition to the comment, would it be possible to add some kind of package-level description of the flow this code takes? It's somewhat hard to follow today already, and the additional ClassDefiner impls makes it even harder. Some kind of README.md or comments in an entry-point class that describe how the classes work together and when we fallback from A->B->C, etc.. would be helpful in explaining this.
Thanks!
Closed
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
Java 17 has removed Unsafe.defineAnonymousClass in favor of Lookup.defineHiddenClass PiperOrigin-RevId: 398348318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 17 has removed
Unsafe.defineAnonymousClassin favour ofLookup.defineHiddenClass