Don't put two copies of every class into the Guava jar. #7741
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_740005364
branch
2 times, most recently
from
98c3f0d to
06c82ef
Compare
We need to compile Guava twice: - once to build the actual classes with `-source 8` (to maintain Java 8 compatibility) - once to build `module-info`, which requires `-source 9` and thus is incompatible with the "main" build I had been under the mistaken impression that the latter compile still needed to pass all the sources. As a result, we had the second compile build `module-info` _and_ all the classes. We then had configuration in `maven-jar-plugin` to ignore the other classes. But the `maven-jar-plugin` configuration doesn't help because we're using `maven-bundle-plugin` instead, at least for the `guava` itself. (I didn't look into `guava-testlib`, `guava-gwt`, or the tests of any module, though note that (IIRC) the only other one that's modularized (and thus might benefit from our module-related `maven-jar-plugin` configuration) is `guava-testlib`.) Luckily, it turns out that we _can_ compile `module-info` by itself. So now the build does that. (Also, bump `maven-jar-plugin` while in the area.) See #6614 (comment) RELNOTES=Removed the extra copy of each class from the Guava jar. The extra copies were an accidental addition from the modularization work in [Guava 33.4.5](https://github.com/google/guava/releases/tag/v33.4.5). PiperOrigin-RevId: 740019355
copybara-service
bot
force-pushed
the
test_740005364
branch
from
06c82ef to
6dcc4ef
Compare
This was referenced Mar 25, 2025
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't put two copies of every class into the Guava jar.
We need to compile Guava twice:
-source 8(to maintain Java 8 compatibility)module-info, which requires-source 9and thus is incompatible with the "main" buildI had been under the mistaken impression that the latter compile still needed to pass all the sources. As a result, we had the second compile build
module-infoand all the classes. We then had configuration inmaven-jar-pluginto ignore the other classes.But the
maven-jar-pluginconfiguration doesn't help because we're usingmaven-bundle-plugininstead, at least for theguavaitself. (I didn't look intoguava-testlib,guava-gwt, or the tests of any module, though note that (IIRC) the only other one that's modularized (and thus might benefit from our module-relatedmaven-jar-pluginconfiguration) isguava-testlib.)Luckily, it turns out that we can compile
module-infoby itself. So now the build does that.(Also, bump
maven-jar-pluginwhile in the area.)See #6614 (comment)
RELNOTES=Removed the extra copy of each class from the Guava jar. The extra copies were an accidental addition from the modularization work in Guava 33.4.5.