Skip to content

Conversation

@copybara-service
Copy link
Contributor

@copybara-service copybara-service bot commented Jul 26, 2021

Deprecate buggy murmur3_32 and introduce murmur3_32_fixed.

The bug was found by @findepi who also contributed the fix and the new tests via #5649.

Fixes #5648.

RELNOTES=hash: Deprecated buggy murmur3_32, and introduced murmur3_32_fixed.

@google-cla google-cla bot added the cla: yes label Jul 26, 2021
@copybara-service copybara-service bot force-pushed the test_386953108 branch 4 times, most recently from 385f664 to f0164f3 Compare August 2, 2021 01:21
@copybara-service copybara-service bot changed the title Fix a bug in hashing strings with non-BMP chars using Murmur3_32. Deprecate buggy murmur3_32 and introduce murmur3_32_fixed. Sep 7, 2021
The bug was found by @findepi who also contributed the fix and the new tests via #5649.

Fixes #5648.

RELNOTES=`hash`: Deprecated buggy `murmur3_32`, and introduced `murmur3_32_fixed`.
PiperOrigin-RevId: 386953108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect hash result from murmur3_32 with String input containing surrogate pairs

1 participant