Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump typescript version #859

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

tonycoco
Copy link
Contributor

Fixes #853

Copy link
Collaborator

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will defer to others to see if they have any objections.

@ddelgrosso1 ddelgrosso1 assigned ddelgrosso1 and sofisl and unassigned ddelgrosso1 Mar 21, 2024
@ddelgrosso1 ddelgrosso1 self-requested a review March 21, 2024 17:49
@ddelgrosso1
Copy link
Collaborator

ddelgrosso1 commented Mar 21, 2024

Just noticed the commit message, I'm not sure why this repo isn't enforcing it but it should follow conventional commits, something like chore(deps): bump typescript version

@tonycoco
Copy link
Contributor Author

Fixed commit-msg.

@tonycoco tonycoco changed the title Bumps TypeScript version to ~5.4.3 chore(deps): bump typescript version Mar 21, 2024
@alexander-fenster alexander-fenster merged commit ffb3e2c into google:main Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript version warning
4 participants